cms-gem-daq-project / gem-plotting-tools

Repository for GEM commissioning plotting tools
GNU General Public License v3.0
1 stars 26 forks source link

Change Dead Channel Cut Defaults to v3 Compatible Values #190

Closed bdorney closed 5 years ago

bdorney commented 5 years ago

Brief summary of issue

Right now the default dead channel cuts, which identify a channel as dead, are for the VFAT2 ASIC. We need to change these defaults to be for VFAT3 (case of no cooling circuit present), using medium VFAT3 gain and comparator in CFD mode (see General Overview of VFAT3).

Types of issue

Expected Behavior

The defaults shown below:

https://github.com/cms-gem-daq-project/gem-plotting-tools/blob/78c88741fbe292f37476c79ffad108a137c1aa27/anaUltraScurve.py#L178-L183

Should be taken to be for VFAT3 (case of no cooling circuit attached, medium VFAT3 gain and comparator in CFD mode) rather than for VFAT2.

Current Behavior

Defaults reflect the VFAT2 case.

Context (for feature requests)

Defaults reflect VFAT2 case and is not the same charge for VFAT3.

Your Environment

bdorney commented 5 years ago

Closed by #192