cms-gem-daq-project / gem-plotting-tools

Repository for GEM commissioning plotting tools
GNU General Public License v3.0
1 stars 26 forks source link

Update anaUltraScurve.py to no longer use vfat2 dead chan cut as default; Addresses Issue 190 #192

Closed fsimone91 closed 5 years ago

fsimone91 commented 5 years ago

Set the isVFAT3 option as default option Updated the deadChanCutHigh and deadChanCutLow for the v3 electronics

Addresses #190

Description

Default option now is the isVFAT3 option. The default values for deadChanCutHigh and deadChanCutLow are different in the isVFAT3 and isVFAT2 cases, so:

Sigma values for v3 electronics: plot of sigma at zero added capacitance for each VFAT position, at ARM_DAC 100 and Medium Gain summary plot for all VFATs

Types of changes

Motivation and Context

Open Issue: https://github.com/cms-gem-daq-project/gem-plotting-tools/issues/190

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

bdorney commented 5 years ago

Also you'll need to update your local develop branch.

You'll need to do something like:

git fetch -p
git pull cms-gem-daq-project develop

Where cms-gem-daq-project is the name of the central repo that you have in your .git/config file; if you cloned directly from the central repository this will be called origin.

In the future it's a good idea to keep your local develop branch sync'd with the remote (cms-gem-daq-project) develop branch and then branch off of it when you want to change the code/create a new feature. For example:

git fetch -p
git checkout develop
git pull cms-gem-daq-project #this makes sure you're even with the remote repository
git checkout -b myCoolNewFeatureBranch
# make your code changes and commit them
git push fsimone91 myCoolNewFeatureBranch
bdorney commented 5 years ago

You can try to test your changes by building the package, installing it your python virtual environment and re-analyzing old data.

Build & installation instructions are available here. Take note of the info about setting up the gembuild repo.