[Bug Fix]: in DAC scan analysis, link should be compared with a single number

AndrewLevin commented 5 years ago

The link branch should be compared with a single number instead of a triplet.

Description

ohKey is a triplet while vfatArray['link'] is a single integer, so a comparison of them will always be false. In this pull request, ohKey is replaced by entry['link'] in the comparison.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context

This is causing the DAC scan analysis to produce empty results.

How Has This Been Tested?

Yes, it has been tested on the coffin setup.

Screenshots (if appropriate):

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

bdorney commented 5 years ago

You haven’t setup your chamberInfo.py correctly, see example:

https://github.com/cms-gem-daq-project/gem-plotting-tools/blob/develop/mapping/chamberInfo.py

A tuple key value is expected.

AndrewLevin commented 5 years ago

Sorry, I don't understand. vfatArray['link'] is a branch in dacScanTree

vfatArray = rp.tree2array(tree=dacScanTree,branches=list_bNames)

It should be a single number, and so it should not be compared with a triplet.

bdorney commented 5 years ago

Yes I see. My mistake.

bdorney commented 5 years ago

Please squash your git commit history as well.

AndrewLevin commented 5 years ago

squashed into one commit

AndrewLevin commented 5 years ago

fixed

jsturdy commented 5 years ago

@bdorney is this the PR you wanted reviewed? It is still blocked by your previous change request

cms-gem-daq-project / gem-plotting-tools