Bug Report: plotSbitThreshComp.py uses out of date filepath & TObject names when loading input data - Githubissues

cms-gem-daq-project / gem-plotting-tools

Repository for GEM commissioning plotting tools

GNU General Public License v3.0

1 stars 26 forks source link

Bug Report: plotSbitThreshComp.py uses out of date filepath & TObject names when loading input data #196

Closed bdorney closed 5 years ago

bdorney commented 5 years ago

Brief summary of issue

The plotSbitThreshComp.py tool is out of data and needs to be updated to use the correct filepath and TObject name within the output TFile.

Types of issue

[x] Bug report (report an issue with the code)
[ ] Feature request (request for change which adds functionality)

Expected Behavior

The following lines:

https://github.com/cms-gem-daq-project/gem-plotting-tools/blob/47f5c1e0dde7aeb7913184f10b325402678bb731/macros/plotSbitThreshComp.py#L124-L125

Should be changed to match the directory structure created:

https://github.com/cms-gem-daq-project/gem-plotting-tools/blob/47f5c1e0dde7aeb7913184f10b325402678bb731/utils/anautilities.py#L1270-L1277

And match the TObject names created:

https://github.com/cms-gem-daq-project/gem-plotting-tools/blob/47f5c1e0dde7aeb7913184f10b325402678bb731/utils/anautilities.py#L1184-L1199

Current Behavior

The following lines:

https://github.com/cms-gem-daq-project/gem-plotting-tools/blob/47f5c1e0dde7aeb7913184f10b325402678bb731/macros/plotSbitThreshComp.py#L124-L125

will result in a nullptr being returned and the macro will crash upon execution.

Context (for feature requests)

Need to be able to compare sbit threshold measurements easily.

Your Environment

Version used: 47f5c1e0dde7aeb7913184f10b325402678bb731

bdorney commented 5 years ago

Closed by #205