cms-gem-daq-project / gem-plotting-tools

Repository for GEM commissioning plotting tools
GNU General Public License v3.0
1 stars 26 forks source link

Fix bug in anaDACScan.py (issue 197) #198

Closed fsimone91 closed 5 years ago

fsimone91 commented 5 years ago

Description

Correct typo in the line to specialize the .png name for different dacScan

Types of changes

Motivation and Context

Addressing issue #197

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

bdorney commented 5 years ago

Can you clean up your github history by squashing those commits four commits into one commit? You can make the commit message "Addressing issue #197" and then it will automatically link to the issue on the github page.

A nice tutorial on how to interactively squash your commits by rebase'ing can be seen here: https://dev.to/blakedeboer/beginners-guide-to-interactive-rebasing-1ob

e.g.

git checkout develop
git fetch -p
git pull origin develop
git checkout fsimone91-patch-2
git rebase -i develop

This will then start the interactive rebasing and allow you to squash those commits.

jsturdy commented 5 years ago

If the only objective is to have the multiple commits squashed, this can be done by the maintainer using the Squash and merge option (they will then also have the option of selecting the commit message)