search

cms-gem-daq-project / gem-plotting-tools

Repository for GEM commissioning plotting tools
GNU General Public License v3.0
1 stars 26 forks source link

updating macro for dacScan comparison #199

Closed adeiorio closed 5 years ago

adeiorio commented 5 years ago

Description

Types of changes

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

bdorney commented 5 years ago

@adeiorio one thing you'll need to do here would be to fill out the template form when submitting a PR. You need to fill out the text in each area and not leave it blank.

Additionally you should not make use excessively of subprocess.call (which is what you're doing by not encapsulating things inside a main block/function definitions/etc...). Try to clean this up a bit.

I think a better location for this to go would be the macros/ subdirectory. For this you'll need to do a git mv, e.g.:

git mv  dacScanComparison2.py macros/ dacScanComp.py

This also would need documentation written in the sphinx style. See for example lines 3-53 of anaDACScan.py. For this you'll also need to edit:

And you'll need to create a man page for it, see for example:

These are needed to ensure that the doc will build automatically.

Finally, this would need a rebase as it's not up-to-date with the develop branch.

bdorney commented 5 years ago

@adeiorio you'll need to rebase this branch since it's out of date with develop.

If you are unsure how to do that I'd be happy to show you.

adeiorio commented 5 years ago

@adeiorio you'll need to rebase this branch since it's out of date with develop.

If you are unsure how to do that I'd be happy to show you.

@bdorney I'd like to have more detailed instruction on this just to be sure to run the right command.

mexanick commented 5 years ago

any progress on this? @bdorney @adeiorio

mexanick commented 5 years ago

Since there was no activity in this PR for a long time, it is considered as stale and subjected to be closed.