cms-gem-daq-project / gem-plotting-tools

Repository for GEM commissioning plotting tools
GNU General Public License v3.0
1 stars 26 forks source link

Feature Request: Update ana_scans.py #202

Closed bdorney closed 5 years ago

bdorney commented 5 years ago

Brief summary of issue

The ana_scans.py tool is extremely out of date. It will need significant updating. Many analysis routines have completely changed or need updates to how they are handled. In some cases scan analysis tools are not even present in the tool.

Supercedes issues:

Types of issue

Expected Behavior

The ana_scans.py tool should be updated to accommodate subparsers similar to how run_scans.py works. There should be a subparser that corresponds to each of the following tools:

In all cases the subparser should take at minimum an input scandate argument. Additionally all subparsers should take a set of mutually exclusive arguments:

In the case of scans that put multiple detectors worth of information in the outputfile (e.g. dacScanV3.py, sbitThreshScanParallel.py) the mutually exclusive argument will be used to map the geographic address to a detector name.

The following subparsers should enable the possibility for analysis in parallel:

If a particular scan application requires a series of calibration coefficients this should be determined from a DB query.

Current Behavior

ana_scans.py is broken.

Context (for feature requests)

Right now the QC8 shift team has been writing one off scripts to serially analyze different scan routines and this is taking a lot of time. This should be addressed to decrease the turnaround from calibration scan to plot.

Additionally there are a lot of bells and whistles that are needed for some tools and it would be easier if the $USER did not need to worry about this.

Your Environment

bdorney commented 5 years ago

Closed by #225