cms-gem-daq-project / gem-plotting-tools

Repository for GEM commissioning plotting tools
GNU General Public License v3.0
1 stars 26 forks source link

Updating default highNoiseCut value in anaUltraScurve.py from 1.0 to 3.0 fC #207

Closed giovanni-mocellin closed 5 years ago

giovanni-mocellin commented 5 years ago

Description

Updating the default value of --highNoiseCut in anaUltraScurve.py from 1.0 to 3.0 fC.

Types of changes

Motivation and Context

Since we noticed that the default cut on the noise value was to low for our needs in the cosmic stand and we got entire VFATs with masked channels, after a thorough study of the noise, we decided to change the default value. From the original value of 1.0 fC, we have changed it now to 3.0 fC. It can be clearly seen by the attached plots that it is more than reasonable and that it permits us to mask less than 1% of the strips because of noise.

How Has This Been Tested?

The change have been tested re-analysing a trim run with the new cut value.

Screenshots (if appropriate):

Checklist:

Plot 1: Integral of number of strips that have noise above the value 'x' for all the scurves analysed: /data/bigdisk/GEM-Data-Taking/GE11_QC8/GE11-X-S-INDIA-0004/scurve/2019.05.17.15.43/SCurveData/SCurveFitData.root /data/bigdisk/GEM-Data-Taking/GE11_QC8/GE11-X-S-INDIA-0009/scurve/2019.05.17.15.43/SCurveData/SCurveFitData.root /data/bigdisk/GEM-Data-Taking/GE11_QC8/GE11-X-S-INDIA-0015/scurve/2019.05.16.17.28/SCurveData/SCurveFitData.root

ERFnoise1Dall

Plot 2: same as plot 1, but Y axis normalised to the total value of strips (to get the percentage)

ERFnoise1DallNorm

bdorney commented 5 years ago

When you originally created this PR there was a set of text that was already in the dialog box. This was used to act as a template. Could you please fill out that template. The above will not be clear for long term tracking.

giovanni-mocellin commented 5 years ago

Added the requested description

giovanni-mocellin commented 5 years ago

Commented the plots