cms-gem-daq-project / gem-plotting-tools

Repository for GEM commissioning plotting tools
GNU General Public License v3.0
1 stars 26 forks source link

[Bugfix] forgot to import os in armDac calibration parsing function #211

Closed AndrewLevin closed 5 years ago

AndrewLevin commented 5 years ago

import os statement was missing

Description

One line change.

Types of changes

Motivation and Context

Would crash if it ever reaches this line, although it seems PyROOT is not actually throwing IOErrors in the current version. Instead it prints:

Error in <TTree::ReadFile>: Cannot open file: ~/test.txt

How Has This Been Tested?

Change is trivial.

Checklist:

mexanick commented 5 years ago

can you please also check other parts of the code. I believe the import os is missing in some other places too

AndrewLevin commented 5 years ago

can you please also check other parts of the code. I believe the import os is missing in some other places too

In anautilities.py, I looked at all of the os.* lines, and am pretty sure this is the only place where the import is missing. I also looked around for other files in gem-plotting-tools where it might be missing but didn't find any.