cms-gem-daq-project / gem-plotting-tools

Repository for GEM commissioning plotting tools
GNU General Public License v3.0
1 stars 26 forks source link

in anaUltraScurve.py, TF1 associated with TTree branch should be copied into #213

Closed AndrewLevin closed 5 years ago

AndrewLevin commented 5 years ago

Bug was causing scurve fit branch to be corrupted in output tree.

Description

Currently, we are correctly handling the scurve_h branch but not the scurve_fit branch:

https://github.com/cms-gem-daq-project/gem-plotting-tools/blob/aacb46da4c6ebe952996ec8695584cd9bc926e9c/anaUltraScurve.py#L581-L583

This pull request uses the same logic involving a holder to handle the scurve_fit branch as the scurve_h branch.

Types of changes

Motivation and Context

Currently, the scurve_fit branch stored in the output tree does not contain the scurve fit, and it will induce a crash if it is read from.

A similar issue was reported https://github.com/cms-gem-daq-project/gem-plotting-tools/issues/63, although it is not clear to me if that is actually address by this pull request.

How Has This Been Tested?

Yes, the bugfix was tested on GE11-X-S-PAK-0005 data taken by the QC8 team.

Screenshots (if appropriate):

Checklist:

jsturdy commented 5 years ago

It appears that you are now out-of-date due to an illegal push by @bdorney 3db691e