Following discussion in GEM Electronics meeting today it was suggested by VFAT3 team that we should reject VFATs found to have one or more DAC's that would need a DAC value out of the DAC range to achieve the proper bias voltage/current.
Types of changes
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to change)
The dacAnalysis function will now run to completion; but just before returning it will throw a ValueError if one or more DAC's are found to need a DAC value to achieve the correct bias voltage/current that would place the DAC out of it's range.
Motivation and Context
We need to be able to reject VFATs that have this DAC behavior; this provides an exception that can be caught by the testConnectivity.py routine to stop the procedure and warn the user.
How Has This Been Tested?
Tested but don't know of a setup where this occurs at present.
Screenshots (if appropriate):
Checklist:
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
Description
Following discussion in GEM Electronics meeting today it was suggested by VFAT3 team that we should reject VFATs found to have one or more DAC's that would need a DAC value out of the DAC range to achieve the proper bias voltage/current.
Types of changes
The
dacAnalysisfunction will now run to completion; but just before returning it will throw aValueErrorif one or more DAC's are found to need a DAC value to achieve the correct bias voltage/current that would place the DAC out of it's range.Motivation and Context
We need to be able to reject VFATs that have this DAC behavior; this provides an exception that can be caught by the
testConnectivity.pyroutine to stop the procedure and warn the user.How Has This Been Tested?
Tested but don't know of a setup where this occurs at present.
Screenshots (if appropriate):
Checklist: