cms-gem-daq-project / gem-plotting-tools

Repository for GEM commissioning plotting tools
GNU General Public License v3.0
1 stars 26 forks source link

Feature Request: calibrateThrDac.py stops putting output in ELOG_PATH #216

Closed bdorney closed 5 years ago

bdorney commented 5 years ago

Brief summary of issue

Since we now have an appropriate location under:

$DATA_PATH/DetectorName/armDacCal/scandate

And a symlink to the calibration file is made so the trim routine can find the right file at runtime the output of calibrateThrDac.py should stop being placed under $ELOG_PATH.

Also change the name of the ARM DAC calibration file from: calFile_CFG_THR_ARM_DAC_DetectorName.txt to calFile_thrArmDAC_DetectorName.txt to make sym linking less tedious and better match with the what the trim routine expects for default input.

Types of issue

Expected Behavior

See above.

Current Behavior

Outputs are placed under $ELOG_PATH so someone needs to manually copy them to a new location after reviewing the data. Bad.

Context (for feature requests)

QOL feature and prevents data loss.

Your Environment

bdorney commented 5 years ago

Addressed by #225