[Bug] Mismatch in Scurve Analysis Cuts Between ana_scans.py & anaUltraScurve.py - Githubissues

cms-gem-daq-project / gem-plotting-tools

Repository for GEM commissioning plotting tools

GNU General Public License v3.0

1 stars 26 forks source link

[Bug] Mismatch in Scurve Analysis Cuts Between ana_scans.py & anaUltraScurve.py #233

Closed bdorney closed 5 years ago

bdorney commented 5 years ago

Brief summary of issue

Cut values for determining channel masks don't match between ana_scans.py and anaUltraScurve.py. The ones in ana_scans.py should be used.

Types of issue

[x] Bug report (report an issue with the code)
[ ] Feature request (request for change which adds functionality)

Expected Behavior

The ones in ana_scans.py should be used.

Current Behavior

The cuts correct cuts in ana_scans.py are:

https://github.com/cms-gem-daq-project/gem-plotting-tools/blob/581e2414844bbba0ce5a122f4c67d7183b9d3daf/ana_scans.py#L828-L832

While the outdated cuts are:

https://github.com/cms-gem-daq-project/gem-plotting-tools/blob/581e2414844bbba0ce5a122f4c67d7183b9d3daf/anaUltraScurve.py#L27-L37

Context (for feature requests)

Potentially bad analysis.

Your Environment

Version used: 581e2414844bbba0ce5a122f4c67d7183b9d3daf
Shell used:

bdorney commented 5 years ago

Closed by #234