[Bug Fix] In DAC scan analysis, ADC error was not being set correctly

[AndrewLevin]

We are applying a scaling factor to the calibrated ADC value, and we should also apply this to its error.

Description

Types of changes

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context

This pull request should resolve the issues with BLCC DAC scans reported in https://indico.cern.ch/event/855869/contributions/3601787/attachments/1929074/3194549/dac_variations_qc8_vs_p5_18-10.2019.pdf

How Has This Been Tested?

Yes, I have tested this on coffin data:

With the HEAD of develop:

With this pull request:

Screenshots (if appropriate):

Checklist:

• [ ] My code follows the code style of this project.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [ ] I have added tests to cover my changes.
• [ ] All new and existing tests passed.

[jsturdy]

So this was not being done for any of the DACs, correct? Just in this case (and maybe also CFG_HYST we saw it more clearly due to the range issue? (can you also show a before/after of CFG_HYST and another that were already appearing "normal"?)

[AndrewLevin]

Yes, this was not being done for any of the DACs, but it has the largest effect for those DACs with scaling factors most different from 1. Because we have a lot of data points to fit, the errors are less important unless they are wildly off, which is the case for BLCC, because the scaling factor is 100.

CFG_HYST DAC scan analysis with HEAD of develop:

CFG_HYST DAC scan analysis with this pull request:

CFG_BIAS_SD_I_BSF DAC scan analysis with HEAD of develop:

CFG_BIAS_SD_I_BSF DAC scan analysis with this pull request: