cms-gem-daq-project / gem-plotting-tools

Repository for GEM commissioning plotting tools
GNU General Public License v3.0
1 stars 26 forks source link

ScanDataFitter constructor incomplete #269

Closed mexanick closed 4 years ago

mexanick commented 4 years ago

Brief summary of issue

S-curve analysis code fails with the following message:

Traceback (most recent call last):
  File "/opt/cmsgemos/bin/anaUltraScurve.py", line 48, in <module>
    args.func(args,args.infilename,args.calFile,args.GEBtype,filePath,vfatList)
  File "/usr/lib/python2.7/site-packages/gempython/gemplotting/utils/scurveAlgos.py", line 314, in anaUltraScurve
    maxChi2=args.maxChi2
TypeError: __init__() got an unexpected keyword argument 'maxChi2'

Types of issue

Expected Behavior

Analysis should complete without errors

Current Behavior

Steps to Reproduce (for bugs)

Run s-curve analysis with gempython_gemplotting-1.5.5-1.76fa9eagit.centos7.python2.7 package

Possible Solution (for bugs)

The constructor of the ScanDataFitter class should include all the arguments it is called with or the caller code has to have maxChi2 parameter removed

Your Environment