search

cms-gem-daq-project / gem-plotting-tools

Repository for GEM commissioning plotting tools
GNU General Public License v3.0
1 stars 26 forks source link

[Bug report] OverflowError on VFat ID in anaUltraScurve.py #271

Closed cgalloni closed 4 years ago

cgalloni commented 4 years ago

Brief summary of issue

While running the anaUltraScurve.py, we encounter problems due to the VFAT ID type which seems to give compatibility issues between the branch in the tree and the type expected from the macro /usr/lib/python2.7/site-packages/gempython/gemplotting/utils/scurveAlgos.py.

Types of issue

Expected Behavior

I should produce the output without any error

Current Behavior

Steps to Reproduce (for bugs)

On gem904daq01, running the commands :

cd /data/bigdisk/GEM-Data-Taking/GE21_Integration/GE11-X-X-XXX/scurve/2019.11.29.15.19
anaUltraScurve.py --calFile=/home/gemuser/ge11_Camp112019_calFile_calDAC.txt SCurveData.root short

produces the error statment:

Traceback (most recent call last):
  File "/opt/cmsgemos/bin/anaUltraScurve.py", line 48, in <module>
    args.func(args,args.infilename,args.calFile,args.GEBtype,filePath,vfatList)
  File "/usr/lib/python2.7/site-packages/gempython/gemplotting/utils/scurveAlgos.py", line 608, in anaUltraScurve
    vfatID[0] = dict_vfatID[vfat]
OverflowError: unsigned long is less than minimum

Possible Solution (for bugs)

Context (for feature requests)

Your Environment

lpetre-ulb commented 4 years ago

Are you using VFATs without Reed-Muller encoded chip ID? If so, it looks like the error is caused by this issue.

mexanick commented 4 years ago

it is exactly that. I developed an easy hack which should cover it, will open a PR after test (just a simple try-except with assigning 0 by default, as the value in case of failure is anyway unphysical)

lpetre-ulb commented 4 years ago

The problem with that kind of easy hack is that it must be applied everywhere an overflow error could happen. Simply fixing anaultraScurve.py is easy, but is there any other places where the same overflow issue could occur?

lpetre-ulb commented 4 years ago

The recommended solution is to update ROOT and PyROOT as explained in #244.