Error Fix - Githubissues

cms-gem-daq-project / gem-plotting-tools

Repository for GEM commissioning plotting tools

GNU General Public License v3.0

1 stars 26 forks source link

Error Fix #272

Closed dteague closed 4 years ago

dteague commented 4 years ago

This is so silly. Fix for issue #262 . Only needed to put a "same" in the draw argument. This only fixes the plotting issue, not the chi2 one (some values are fairly large)

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change

How Has This Been Tested?

Using files provided in issue #262

jsturdy commented 4 years ago

This is confirmed fixed for both GE1/1 and GE2/1 (not sure exactly which files were provided for testing in #262)?

dteague commented 4 years ago

For the test files, it was the zipped up files sent by Laurent in the issue #262 . For the fixed output, that can be seen here

Output of GE21 test here I am working from the US, so some things are acting strange probably as a result, e.g. I can't access bigdisk on the gemdaq machines. So I used a GE21 file and calfile I had lying around for this. On face value, it seems for both cases, the plots look better, though the chi2 error still comes up