Replace nVFATS with nVFats in all instances

cms-gem-daq-project / gem-plotting-tools

Repository for GEM commissioning plotting tools

GNU General Public License v3.0

1 stars 26 forks source link

Replace nVFATS with nVFats in all instances #282

Closed ElizabethRoseStarling closed 4 years ago

ElizabethRoseStarling commented 4 years ago

Description

Replaced nVFATS with nVFats in all instances so iterativeTrim.py can function correctly.

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context

Fixes Issue 280.

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

jsturdy commented 4 years ago

without knowing anything else about the context of this change, coding style consistency would say this change should be nVFATS -> nVFATs (and if this change was made to make something match an nVfats elsewhere, that other location should be changed from nVfats -> nVFATs)

lpetre-ulb commented 4 years ago

The most used variable name is nVFATS:

[lpetre@gem-daq gem-plotting-tools]$ grep -hori nvfats pkg | sort | uniq -c
     15 nVFats
      1 nVFATs        # which is a comment
     99 nVFATS

with nVFats used mainly in fitting/fitScanData.py, three times in chamberInfo.py and once in utils/scurveAlgos.py (for compatibility with the first file).

I guess the simplest change would be to convert the nVFats to nVFATS(which was introduced in the GE2/1 generalizing PR).

The best change for code style consistency would be your suggestion. However, it requires the largest number of changes (with the associated issues) and would probably require changes in the GE2/1 PR from vfatqc-python-scripts.

jsturdy commented 4 years ago

The most used variable name is nVFATS:
[lpetre@gem-daq gem-plotting-tools]$ grep -hori nvfats pkg | sort | uniq -c
     15 nVFats
      1 nVFATs        # which is a comment
     99 nVFATS
with nVFats used mainly in fitting/fitScanData.py, three times in chamberInfo.py and once in utils/scurveAlgos.py (for compatibility with the first file).

I guess the simplest change would be to convert the nVFats to nVFATS(which was introduced in the GE2/1 generalizing PR).

:+1: for least invasive correction as a hotfix, with a potential cleanup later

The best change for code style consistency would be your suggestion. However, it requires the largest number of changes (with the associated issues) and would probably require changes in the GE2/1 PR from vfatqc-python-scripts.

mexanick commented 4 years ago

superseeded by #284