[BugFix] Addressing Multi-valued inflection point issues

bregnery commented 4 years ago

Description

Previously the inflection point finder allowed for multiple values, we have prevented this from happening by selecting the largest value when more than one is selected. Also, it was requested by the shifters for us to remove the red line from the sbit graphs.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context

This bug prevented tests from being run at qc7 and needed to be addressed.

How Has This Been Tested?

anaSBitThresh.py /data/bigdisk/GEM-Data-Taking/GE11_QC8///sbitRate/channelOR//2020.02.12.11.33/SBitRateData.root

echo "File 1"
echo "This tests how the code handles a vfat with a bad vfat"
echo "Please make sure (2,5,4) is filled in your system_specfic_constants.py file"

# This file causes issues because of a zero slope issue
anaSBitThresh.py /data/bigdisk/GEM-Data-Taking/GE11_QC8//sbitRate/channelOR/2019.10.25.13.59/SBitRateData.root

echo "File 2"
echo "This tests how the code handles a detector with missing vfats"
echo "Please make sure (1,2,0) is filled in your system_specfic_constants.py file"

# This file is from the coffin where the detector is missing vfats
anaSBitThresh.py /data/bigdisk/GEM-Data-Taking/GE11_Integration//sbitRate/channelOR//2019.10.24.17.45/SBitRateData.root

Screenshots (if appropriate):

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.

bregnery commented 4 years ago

This is to address issue [#288]

cgalloni commented 4 years ago

@bregnery, can you solve the conflicting files? Maybe with a rebase?

bregnery commented 4 years ago

Ah, yes, sorry, I rebased to a previous tag

bregnery commented 4 years ago

I have added an option inside anautilities for drawing the lines on the graph and for printing the table output in the terminal. These options default to false. The inflection point values are still stored in a .txt file by default.

I have tested this on sbit scans that have multivalued inflection points, missing vfats, and bad sbit lines.

cms-gem-daq-project / gem-plotting-tools