Addresses #64: 3x8 Grid TCanvas Objects Now Follow Physical VFAT Layout

[bdorney]

Description

With superchamber construction coming soon we will be doing a lot of benchtop testing before/after assembly of detectors. To reduce confusion I have made the TCanvas objects that produced 3x8 grid plots follow the physical VFAT ordering when looking from above the detector with the narrow (wide) base of the trapezoid on your left (right).

Addresses #64

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [X] Breaking change (fix or feature that would cause existing functionality to change)

The "Breaking Change" may not be the correct designation, but it will change the order on how plots are shown and may catch certain users off guard. Overall though I believe this will save trouble in the long run.

Motivation and Context

When looking at 3x8 grid plots produced by our tools the VFAT numbering in the plot does not match the physical layout of the detector, e.g. VFATs 0->7 appear where VFATs 16-23 are located. During the mass production of superchambers and subsequent in lab testing by non-experts this has a strong possibility to generate confusion and/or mistakes.

How Has This Been Tested?

Reanalyzed old data.

Screenshots (if appropriate):

Checklist:

• [X] My code follows the code style of this project.
• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [X] I have added tests to cover my changes.
• [X] All new and existing tests passed.

[jsturdy]

Can you add an old plot and describe the confusion you feel will arise? (I want to see if I can similarly confuse myself with the new layout)

[bdorney]

So for example when we were reviewing the old GEMINIm01L1 we wanted to replace VFAT4 because there was a concern it had burned inputs. At first the wrong chip (VFAT20) was removed because the operator wanted to reference the plot and not the physical layout. This image shows the original ordering which does not follow the physical detector layout:

[bdorney]

Here's the requested image: