Open mexanick opened 7 years ago
Is it possible to get more descriptive documentation about the code.
Unfortunately we don't have a good developers doc for this... I attach a user doc we have. GEM_Light_DQM_Reference_Guide-2.pdf However, this is a Django-based project, so you can take a look at Django's doc page to understand the structure of the project and how it works in general: https://docs.djangoproject.com/en/1.11/intro/tutorial01/
for simple DB interaction take a look here: https://github.com/mexanick/cmsgemos/blob/develop/gempython/utils/db/query.py The function configure_db can be run standalone, the module query already contains all needed dependencies and can be considered as a minimal example
We need a testing DB for this purpose. I propose to use the gem904daq01 as testing machine. @jsturdy, could you please check if we still have a sandbox DB (I believe we had it some time ago) there? Also @MuhammadHasib , do you have an account at gem904daq01 machine? If not, please send to @jsturdy your nice user name.
Yes I do, I am able to login on gem904daq01 machine.
Brief summary of issue
We need to implement configuration tags and improve chamber naming to relate it more easily to the central confDB names
Types of issue
Expected Behavior
Currently this field is used to handle both the chamber name and the optical link number: https://github.com/cms-gem-daq-project/ldqm-browser/blob/a0ba4356537bfb6c59930c11ed9c47d5d1a65fe8/LightDQM/ldqm_db/models.py#L25 I suggest to add another field to track the optical link and use this field as real name (e.g. GEMINI29L2). This change should be correctly linked and carefully checked w.r.t gem-light-dqm code so that interface works correctly and finds the proper plots to display.
We also should add the field around this line: https://github.com/cms-gem-daq-project/ldqm-browser/blob/a0ba4356537bfb6c59930c11ed9c47d5d1a65fe8/LightDQM/ldqm_db/models.py#L37 with the configuration tag. We also need to write an utility for uploading and tagging new configuration into the DB. After this feature is implemented, an update to cmsgemos should follow to use the configuration tag instead of querying the hardware.
We should ensure correct usage of https://github.com/cms-gem-daq-project/ldqm-browser/blob/a0ba4356537bfb6c59930c11ed9c47d5d1a65fe8/LightDQM/ldqm_db/models.py#L24 which should carry an information whether chamber is short or long and use it correctly within gem-light-dqm