Bug Fix: Resolves #17, jtagCommand() generates IndexError if drReadOhList is nonsequential

bdorney commented 6 years ago

Description

This should resolve issue #17.

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context

Since jtagCommand() returns a list if drReadOhList is nonsequential the indices of of the return of jtagCommand() will not match the elements in the input drReadOhList and generate an IndexError

How Has This Been Tested?

With one OH, link 0:

$ sca.py eagle63 0x1 sysmon
...
...
=== OH #0 ===Core temp = -273.15, voltage #1 = 0.298828125, voltage #2 = 0.298828125 

=== OH #0 ===Core temp = 34.9440917969, voltage #1 = 1.0224609375, voltage #2 = 2.4609375

With one OH, link 1:

$ sca.py eagle63 0x2 sysmon
...
...
=== OH #1 ===Core temp = 31.9911132813, voltage #1 = 1.0341796875, voltage #2 = 2.5546875 

=== OH #1 ===Core temp = 31.9911132813, voltage #1 = 1.0341796875, voltage #2 = 2.5546875

With two OH's, links 0 & 1:

$ sca.py eagle63 0x3 sysmon
...
...
=== OH #0 ===Core temp = 34.4519287109, voltage #1 = 1.0224609375, voltage #2 = 2.4609375 

=== OH #1 ===Core temp = 31.9911132813, voltage #1 = 1.0341796875, voltage #2 = 2.5546875 

=== OH #0 ===Core temp = 34.4519287109, voltage #1 = 1.0224609375, voltage #2 = 2.4609375 

=== OH #1 ===Core temp = 31.9911132813, voltage #1 = 1.0341796875, voltage #2 = 2.5546875

Checklist:

[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[X] I have added tests to cover my changes.
[X] All new and existing tests passed.

mexanick commented 6 years ago

Are the values evolving in time? We had a problem before (might be FW-related) with values not changing after the first read...

bdorney commented 6 years ago

Are the values evolving in time? We had a problem before (might be FW-related) with values not changing after the first read...

I did not test for that; was only testing to resolve the sw crash. Probably should be a separate issue.

bdorney commented 6 years ago

It seems the travis-ci build failed due to a bad env setting in the build:

Makefile:2: *** "Error: PETA_STAGE environment variable not set.  Change to the root of your PetaLinux install, and source the settings.sh file".  Stop.

I guess this is expected? Is the travis-ci working fully for this repo yet?

bdorney commented 6 years ago

Are the values evolving in time? We had a problem before (might be FW-related) with values not changing after the first read...

I was told they were evolving with time by Gilles but I did not test myself.

cms-gem-daq-project / reg_utils