Bug Fix: NameError in gbt.py #23

bdorney commented 6 years ago

Description

Addresses #23.

Fixed missing sys import and now the user will no longer be able to call this method from the DAQ machine.

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context

NameError generated due to missing import. Also prevents being called from the DAQ machine.

How Has This Been Tested?

Change was trivial.

Screenshots (if appropriate):

Checklist:

[X] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

bdorney commented 6 years ago

Question: should we support this from the DAQ machine? If so this would likely turn to a breaking change since the cardName option would need to be added.

jsturdy commented 6 years ago

Question: should we support this from the DAQ machine? If so this would likely turn to a breaking change since the cardName option would need to be added.

@mexanick was looking into this, probably the packaging will be changed such that this (and any other CTP7 only) file(s) are not put into the non-CTP7 rpm

cms-gem-daq-project / reg_utils