added a per-OH hard reset remove function

evka85 commented 6 years ago

the new fpga_remove_hard_reset() function removes the hard reset for selected OHs

Description

fpga_keep_hard_reset() function asserts hard reset and keeps it asserted for selected OHs the new fpga_remove_hard_reset() function removes the hard reset for selected OHs If sending a hard reset to a specific set of OHs is desired, one should call fpga_keep_hard_reset() and then call fpga_remove_hard_reset() with the same OHlist

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context

Sending a single hard reset to specific OHs is desired by the operations team

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

bdorney commented 6 years ago

can you integrate this into sca.py under fpgaHeldInHardReset(args)

evka85 commented 6 years ago

Should we just change the functionality of the existing fpgaHeldInHardReset() function and the corresponding hh command, or should I introduce a new user function for this? I guess there's not much need for asserting the hard reset and keeping it asserted, so we could just as well redefine the functionality of the hh command, but let me know your thoughts on this.

evka85 commented 6 years ago

I suppose the h function could be named something like a "synchronous hard-reset done on all OHs connected to this AMC at the same time", and the hh function could be described as "manual hard-reset on the selected OHs defined by the ohMask, which is not guaranteed to arrive to all selected OHs at the same time"

mexanick commented 6 years ago

I'm fine with redefining the hh command. I don't recall any significant usage of it lately.

evka85 commented 6 years ago

Ok, hmm I have a new commit, but can't see how to include it in this pull request.... Can you help?

evka85 commented 6 years ago

Should I just delete this PR and create a new one?..

mexanick commented 6 years ago

no. Simply push your local commit. It will be added to this PR automatically

evka85 commented 6 years ago

The continuous integration check failed, but it seems it's due to a reason unrelated to my changes? Makefile:2: *** "Error: PETA_STAGE environment variable not set. Change to the root of your PetaLinux install, and source the settings.sh file". Stop.

mexanick commented 6 years ago

@evka85 yeah, this is due to issues with cross-compilation

cms-gem-daq-project / reg_utils