search

cms-gem-daq-project / reg_utils

0 stars 9 forks source link

[duplication] sca_utils and sca_common_utils code duplication #34

Open jsturdy opened 5 years ago

jsturdy commented 5 years ago

Brief summary of issue

Duplicate code, probably from migration to new structure:

https://github.com/cms-gem-daq-project/reg_utils/blob/917db4493a5d383c12c647118e2c90cd7339ac42/python/reg_interface/common/sca_utils.py#L126-L151

duplicates

https://github.com/cms-gem-daq-project/reg_utils/blob/917db4493a5d383c12c647118e2c90cd7339ac42/python/reg_interface/common/sca_common_utils.py#L13-L38

Types of issue

Possible Solution (for bugs)

Remove L126-L151 from sca_utils.py, as the import in L8 brings them in from sca_common_utils.py

bdorney commented 5 years ago

Still relevant; although line numbers appear to now be:

https://github.com/cms-gem-daq-project/reg_utils/blob/2879f89d67994212d0d71f0616224195edc79ea9/python/reg_interface/common/sca_utils.py#L119-L134