cms-gem-daq-project / xhal

XHAL interface library
0 stars 10 forks source link

New Feature: ultra scan modules for v2b electronics #30

Closed bdorney closed 6 years ago

bdorney commented 7 years ago

Description

I have expanded the scan tools for v3 electronics to also work with v2b electronics. The modules identify at runtime what behavior should be executed.

Requires: https://github.com/cms-gem-daq-project/ctp7_modules/pull/13

Types of changes

Motivation and Context

If we are moving toward RPC/XHAL framework for CTP7 we should have the tools for both v2b and v3 electronics rather than having to move back and forth between libraries.

How Has This Been Tested?

A complete working example is shown here: http://cmsonline.cern.ch/cms-elog/1020178

For the v2b electronics I took a per channel threshold scan using the ipbus/uhal framework and then compared the results obtained when taking data with the rpc/xhal tools shown here. As can be seen the behavior is identical.

Additionally as shown the tools also work on v3 electronics.

Screenshots (if appropriate):

See above elog post.

Checklist:

bdorney commented 7 years ago

Actually I want to test with a latency scan first to make sure that no changes are needed when using an external trigger source

mexanick commented 6 years ago

@bdorney, is this a final revision of the PR?