cms-gem-daq-project / xhal

XHAL interface library
0 stars 10 forks source link

release 3.2.0 patch1 #66

Closed mexanick closed 6 years ago

mexanick commented 6 years ago

Integrating changes for daq_suite and fixing execute method override in ri_promt

Description

Types of changes

Motivation and Context

Required to run the automated setup scripts from gemctp7user repo

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

mexanick commented 6 years ago

The part under daq_suite is not yet final, this will be fixed later. The main need for the patch is under reg_interface

On May 8, 2018 13:42, Jared Sturdy notifications@github.com wrote:

@jsturdy commented on this pull request.


In python/daq_suite/daq_suite/settings.pyhttps://github.com/cms-gem-daq-project/xhal/pull/66#discussion_r186698255:

@@ -25,7 +25,7 @@

SECURITY WARNING: don't run with debug turned on in production!

DEBUG = True

-ALLOWED_HOSTS = ['kvm-s3562-1-ip151-107.cms','cosmicstandtif.cern.ch','gem904daq01.cern.ch'] +ALLOWED_HOSTS = ['kvm-s3562-1-ip151-107.cms','gem904qc8daq.cern.ch','gem904daq01.cern.ch', 'gem904qc8daq']

can this (or the thing that checks ALLOWED_HOSTS) support a regex?


In python/daq_suite/daq_suite/urls.pyhttps://github.com/cms-gem-daq-project/xhal/pull/66#discussion_r186698368:

@@ -29,4 +29,4 @@ url(r'^monitoring/(\w.+)/', read_gem_system_module), ] parseXML() -rpc_connect("eagle34") +rpc_connect("eagle26")

is this a tester file? or why is this hardcoded?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/cms-gem-daq-project/xhal/pull/66#pullrequestreview-118326556, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AHFalie33uuk6Mw10ZgXIumzzPaXlrRIks5twYRqgaJpZM4T1QTy.