search

cms-jet / JetMETAnalysis

2 stars 33 forks source link

Updates to run tau calibration. #5

Closed Calpas closed 9 years ago

aperloff commented 9 years ago

@Calpas Please use the standard 4 spaces (or equivalent tab) for indentation.

aperloff commented 9 years ago

@Calpas So I really have no comments on your python files in the test directory. Those are entirely up to you. As for the other files, I've written quite a few comments/questions. Please know, I'm not trying to be difficult. I truly want to make this as good a piece of code as possible while keeping it backwards compatible and future proofed. Let me know if you think some of my concerns are unwarranted.

Calpas commented 9 years ago

Thank you for your comment, always good to have another point of view.

Cheers, Betty