search

cms-jet / JetMETAnalysis

2 stars 33 forks source link

modified code for HLT JEC #8

Closed Fengwangdong closed 8 years ago

Fengwangdong commented 8 years ago

Alexx,

Since I modified the offline code to adapt to HLT case last year, there are a lot of differences between our codes due to the update in parallel during these months.

Here are the main differences:

Other changes are maginal differences such as name of included head files or comment lines inside the README.

Cheers, Feng

aperloff commented 8 years ago

Feng,

As far as I can tell all of these ³issues² are solvable, though I haven¹t read any of your code.

  1. I¹m not opposed to adding the unmatched reco jets branch.
  2. Adding a new defaults section for HLT and turning it on with a flag is something we¹ve done in the past. This option/method can be resurrected.
  3. Can¹t comment out Tau algos as the tau group is using them. Can add ak4HLTJet and ak8HLTJet. That¹s not a problem.
  4. Just add a new config file, don¹t delete the others. Since this is a user configurable option when running the executables having more config files is not an issue.
  5. I don¹t understand why JERWriter is having issues. Did you edit it? What changed?
  6. Again, what changed in jet_apply_jec? It¹s such a simple code and should be the same for online and offline jets in the JRA ntuples
  7. The other changes also seem manageable, though I¹d rather comment on them in a case-by-case fashion after I see the code.

From: fengwang notifications@github.com Reply-To: cms-jet/JetMETAnalysis <reply+00495daaa77475f315697ef9ecc8dfcd3595b9e8c1366b8692cf0000000112e80a529 2a169ce0825b0ae@reply.github.com> Date: Friday, February 26, 2016 at 6:42 AM To: cms-jet/JetMETAnalysis JetMETAnalysis@noreply.github.com Subject: [JetMETAnalysis] modified code for HLT JEC (#8)

Alexx,

Since I modified the offline code to adapt to HLT case last year, there are a lot of differences between our codes due to the update in parallel during these months.

Here are the main differences:

Cheers, Feng

You can view, comment on, or merge this pull request online at: https://github.com/cms-jet/JetMETAnalysis/pull/8 Commit Summary