search

cms-jet / JetToolbox

Python framework for configuration of jet tools via the jet toolbox.
https://twiki.cern.ch/twiki/bin/viewauth/CMS/JetToolbox
7 stars 36 forks source link

jetToolbox_91X_v1 tag error in CMSSW_9_4_X release #55

Closed scarletnorberg closed 5 years ago

scarletnorberg commented 6 years ago

I am currently working in a CMSSW_9_4_X release and I have checked out the jetToolbox_91X_v1 tag of the JetToolbox. This was the latest recommended version on the JetToolbox twiki. However, when running the toolbox I get this error:

----- Begin Fatal Exception 15-Feb-2018 12:13:42 CST----------------------- An exception of category ‘ConfigFileReadError’ occurred while [0] Processing the python configuration file named treeMaker_stopRA2.py Exception Message: python encountered the error: <type ‘exceptions.ImportError’> cannot import name hepTopTagPFJetsCHS ----- End Fatal Exception --------

I checked through the CMSSW_9_4_X code base on GitHub and found that hepTopTagPFJetsCHS is no longer available. Is there a recommended workaround? Will a 94X version of the JetToolbox be available soon?

rappoccio commented 6 years ago

We haven't had a chance to update the jet toolbox to 94x. The primary developer is Alejandro who is busy writing his thesis.

kpedro88 commented 6 years ago

@scarletnorberg and I made a fork and fixed it to work in 94X (as far as we can tell): https://github.com/TreeMaker/JetToolbox/tree/jetToolbox_94X

However, there's no 94X branch here to send a PR.

rappoccio commented 6 years ago

@kpedro88 thanks, I made a branch: https://github.com/cms-jet/JetToolbox/tree/jetToolbox_94x

rappoccio commented 6 years ago

@kpedro88 hang on, I am being inconsistent with "94x" versus "94X". I will fix.

rappoccio commented 6 years ago

@kpedro88 https://github.com/cms-jet/JetToolbox/tree/jetToolbox_94X

rappoccio commented 6 years ago

I think you have a line indent problem:

https://github.com/cms-jet/JetToolbox/compare/jetToolbox_94X...TreeMaker:jetToolbox_94X#diff-f1fc8e7a8a193e13cf51904bafa14b26R193

kpedro88 commented 6 years ago

@rappoccio would be better to start the 94X branch from the 91X branch rather than master

kpedro88 commented 6 years ago

I think the apparent indentation problem is due to mixing of tabs and spaces, which is a python no-no that predates any of my modifications in that file

rappoccio commented 6 years ago

@kpedro88 OK I based it on 91x now.

Yes, looks like there are some mixed tabs and spaces. I don't think I can merge this automatically if the indent is there.

kpedro88 commented 6 years ago

the problem is actually caused by some other 94X-related PRs that were merged in the 91X branch after my branch diverged. rebasing to handle appropriately

kpedro88 commented 6 years ago

see #56

rappoccio commented 6 years ago

OK done! Sal

On Tue, Feb 27, 2018 at 4:25 PM, Kevin Pedro notifications@github.com wrote:

see #56 https://github.com/cms-jet/JetToolbox/pull/56

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cms-jet/JetToolbox/issues/55#issuecomment-369031368, or mute the thread https://github.com/notifications/unsubscribe-auth/AEEeuaQGsLddyw4ENJhspDgbW2CLDHRXks5tZHKxgaJpZM4SHn9O .