Various improvements - Githubissues

cms-jet / JetToolbox

Python framework for configuration of jet tools via the jet toolbox.

https://twiki.cern.ch/twiki/bin/viewauth/CMS/JetToolbox

7 stars 36 forks source link

Various improvements #60

Closed kpedro88 closed 6 years ago

kpedro88 commented 6 years ago

Following up on list of suggestions in #59.

A few specific notes:

verbosity levels are: 0 = no printouts, 1 = warnings only, 2 = warnings & info, 3 = warnings, info, debug (2 is the default)
using print() as a function instead of a statement will help with eventual python3 transition
also ported the separate subjetBTagDiscriminator list from #47

DeepFlavour support still needs to be added, but I'm not sure what that entails.

alefisico commented 6 years ago

Hi @kpedro88 sorry for the late reply about this, but I am a bit confused with the associatedTask option. If this is false, then I would need to include a process.endpath = cms.EndPath() in my other python cfg file or what exactly I need to include? Thanks!

kpedro88 commented 6 years ago

@alefisico with associateTask=False, you need to associate the jetTask to a cms.Path() or cms.EndPath().

In TreeMaker, I do the following (to avoid worrying about jetTask separately from my other producers): https://github.com/TreeMaker/TreeMaker/blob/27958323802b39b1da622a7da53e8baf4e50069a/TreeMaker/python/makeTreeFromMiniAOD_cff.py#L905-L914

alefisico commented 6 years ago

ok that was my confusion, you do not only need to associate the jetTask to cms.Path() but also include the module which uses the output collections of the JetToolbox to the path, like in your line 912. I got a question about this and it took me a while to understand this. Thanks, I think I need to add this information in the twiki.