search

cms-l1-dpg / Phase2-L1MenuTools

This repository contains the framework for the measurement of matching efficiencies, trigger turn-on curves, and scalings for the assessment of the physics performance of the CMS Phase-2 L1 Menu.
2 stars 8 forks source link

Use object label as key instead of object name #10

Closed artlbv closed 1 year ago

artlbv commented 1 year ago

Use of e.g. tkIsoPhoton instead of tkPhoton as key in plotting config allows to have several "curves" of the same object compared in the same plot. Now this is not possible as the object name tkPhoton is used in the key.

artlbv commented 1 year ago

@danielhundhausen suggested extending this with an "interface" class between the config and plotter (TBC).

bonanomi commented 1 year ago

I suggest we close this as IIUC it's a duplicate of https://github.com/cms-l1-dpg/Phase2-L1MenuTools/issues/6. (Or we keep only this and close https://github.com/cms-l1-dpg/Phase2-L1MenuTools/issues/6).

If indeed this is #6 , it has been solved in https://github.com/bonanomi/Phase2-L1MenuTools/commit/d279fc4eb418368c2fdfd21a21ee6aa2dd5610de.

Probably it is better to wait for the review and merging of https://github.com/cms-l1-dpg/Phase2-L1MenuTools/pull/14 before opening a PR for this.

bonanomi commented 1 year ago

@artlbv Closing this issue. Solved in https://github.com/cms-l1-dpg/Phase2-L1MenuTools/pull/16.