search

cms-l1-dpg / Phase2-L1MenuTools

This repository contains the framework for the measurement of matching efficiencies, trigger turn-on curves, and scalings for the assessment of the physics performance of the CMS Phase-2 L1 Menu.
2 stars 8 forks source link

add possibility to compare different versions #12

Closed artlbv closed 1 year ago

artlbv commented 1 year ago

Concerns turons scalings etc

bonanomi commented 1 year ago

If the definition of the objects do not change across versions, this should be relatively quick to implement. However I fear that this is not always the case and that the objects (especially L1 objects) definition can change. Having implemented the storage of the plots to json files, probably the quickest way to achieve this is to create a new function that reads the json files and creates a new plot. What do you think?

bonanomi commented 1 year ago

This can now be addressed by compare_plots.py introduced in https://github.com/bonanomi/Phase2-L1MenuTools/commit/e4e94bd8c455b8374f7fc18658bf1b8030f3ec7b. Will open a PR soon. Example output from compare_plots.py (V22 and V26 are identical here because I used the same input, i.e. V22, for both curves):

image

bonanomi commented 1 year ago

@artlbv Closing this issue. Solved in https://github.com/cms-l1-dpg/Phase2-L1MenuTools/pull/16.