search

cms-l1-dpg / Phase2-L1MenuTools

This repository contains the framework for the measurement of matching efficiencies, trigger turn-on curves, and scalings for the assessment of the physics performance of the CMS Phase-2 L1 Menu.
2 stars 8 forks source link

Move to standard venv with lxplus Python3.11 installation and to awkward v2 #46

Closed danielhundhausen closed 7 months ago

danielhundhausen commented 7 months ago

Now Python3.11 is available by default on LXPLUS and we can use this instead of having to install conda. Advantages:

Awkward was updated from version 1 to 2 in this PR. I have tested the caching and turnon plotting scritps which appear to work fine with these modifications. Two changes in awkward were accounted for:

  1. to_parquet changed the where kwarg to destination
  2. slightly different behaviour of ak.cartesian leads to one less dimension in output and no inner zeros (which we previously removed in a separate function)
artlbv commented 7 months ago

slightly different behaviour of ak.cartesian leads to one less dimension in output and no inner zeros (which we previously removed in a separate function)

can this be due to the nested argument? maybe the default changed (though we seem to always set nested to True)

danielhundhausen commented 7 months ago

UPDATE: apparently there is a bug in ak.cartesian so I rolled back the changes to accommodate the different behaviour in turnon_collections.py. We should probably wait with merging this until the bug is fixed.

danielhundhausen commented 7 months ago

All plots can be reproduced with the update included. Here are various comparisons of plots. There were some deviations from the archived plots from Artur which turn out to disappear when reproducing everything with the old setup at the current version of the code on main.