search

cms-l1-dpg / Phase2-L1MenuTools

This repository contains the framework for the measurement of matching efficiencies, trigger turn-on curves, and scalings for the assessment of the physics performance of the CMS Phase-2 L1 Menu.
2 stars 8 forks source link

Multiple test object from the same parquet file #6

Closed artlbv closed 1 year ago

artlbv commented 1 year ago

In the current (C++) fwk there are cases in which multiple test objects are derived from the same collection. For example, tkElectron and tkElectronIso in our jargon would be defined as:

  test_objects:
    tkElectron:
      suffix: "Pt"
      label: "TkElectron"
      cuts:
        - "abs({eta}) < 2.4"
        - "{passesloosetrackid} == 1"
    tkElectronIso:
      suffix: "Pt"
      label: "TkElectron Iso"
      iso_BB: 0.13
      iso_EE: 0.28
      iso_branch: "trkiso"
      quality_id: "QUAL_BarrelNoneEndcap3"
      cuts:
        - "abs({eta}) < 2.4"

But the code cannot handle this situation, because it tries to look for V22_DY_tkElectronIso.parquet file, which does not exist. Both these objects (tkElectron and tkElectronIso in fact should be loaded from the same file: V22_DY_tkElectron.parquet).

bonanomi commented 1 year ago

Solved in https://github.com/bonanomi/Phase2-L1MenuTools/commit/d279fc4eb418368c2fdfd21a21ee6aa2dd5610de, PR yet to be opened. Probably it is better to wait for the review and merging of https://github.com/cms-l1-dpg/Phase2-L1MenuTools/pull/14.

bonanomi commented 1 year ago

https://github.com/cms-l1-dpg/Phase2-L1MenuTools/pull/16