Discrepancies in the GT vs L1/Menu objects - Githubissues

cms-l1-dpg / Phase2-L1Nano

NanoAOD ntupler for Phase-2 L1 Objects

Apache License 2.0

1 stars 5 forks source link

Discrepancies in the GT vs L1/Menu objects #2

Open artlbv opened 10 months ago

artlbv commented 10 months ago

From https://mattermost.web.cern.ch/cms-l1t-dpg/pl/86ju5sapa7b43jtkxh7agg9iww

[x] tkPhoton: trkIsoPV used in the GT, trkIso in the "menu/L1"
[x] tkEle/nnTau z0 are scaled by *2 due to some ap_type mismatch
[ ] gmtTkMuon charge is inverted in the GT
[ ] gmtTkMuon quality wrapping (8 vs 9) bits

I have marked with #FIXME the places where fixes where done or are needed in https://github.com/cms-l1-dpg/Phase2-L1Nano/blob/main/python/l1Ph2Nano_cff.py

artlbv commented 10 months ago

Also another issue which was fixed here is the old L1vertex collection. Addressed in these PRs:

artlbv commented 10 months ago

TkElectron/nnTau is addressed by this PR: https://github.com/cms-l1t-offline/cmssw/pull/1168

artlbv commented 9 months ago

TkPhoton isolation addressed here: https://github.com/cms-l1t-offline/cmssw/pull/1181