cms-l1-dpg / Phase2-L1Nano

NanoAOD ntupler for Phase-2 L1 Objects
Apache License 2.0
1 stars 6 forks source link

Add fixes for validated GTT Objects #21

Closed NJManganelli closed 8 months ago

NJManganelli commented 8 months ago

This recipe fixes the GTT MHT discrepancy (including a phi range issue, fixing a wraparound past +pi to be in [-pi, 0) instead), as well as a number of other issues with hw values stored for GTT Objects, and adds fields for the Extended TrackJets. In conjunction with https://github.com/cms-l1t-offline/cmssw/pull/1217 and https://github.com/cms-sw/cmssw/pull/44334, there should be agreement on the data members stored for almost all these objects (the above PRs only affect the hwZ0 and hw(Sum)Pt of the TrackJets and Vertices; float values should be unperturbed).

NJManganelli commented 8 months ago

I think all comments are addressed currently

artlbv commented 8 months ago

Merged though I would like to still understand this et<>pt: https://github.com/cms-l1-dpg/Phase2-L1Nano/pull/21#discussion_r1520276996

NJManganelli commented 8 months ago

I committed that locally but forgot to push upstream

diff --git a/python/l1tPh2Nanotables_cff.py b/python/l1tPh2Nanotables_cff.py
index 8740bf9..281340a 100644
--- a/python/l1tPh2Nanotables_cff.py
+++ b/python/l1tPh2Nanotables_cff.py
@@ -63,7 +63,7 @@ gttEtSumTable = cms.EDProducer(
     singleton = cms.bool(True), # the number of entries is variable
     variables = cms.PSet(
         # as in https://github.com/cms-l1t-offline/cmssw/blob/phase2-l1t-integration-14_0_0_pre3/L1Trigger/L1TTrackMatch/interface/L1TkEtMissEmuAlgo.h#L50
-        pt = Var("hwPt() * 0.03125", float, doc = "Track MET"),
+        pt = Var("et", float, doc = "Track MET"),
artlbv commented 8 months ago

ok, pushed that directly here: https://github.com/cms-l1-dpg/Phase2-L1Nano/commit/8278525cd0312d007f02b3982caeece15c9e5f8a

NJManganelli commented 8 months ago

Perfect, thanks Artur!