search

cms-l1t-offline / cms-l1t-analysis

0 stars 21 forks source link

[WIP] Adding HW vs Emulated overlaid rates plots. (Do not merge!) #114

Closed professor-calculus closed 6 years ago

professor-calculus commented 6 years ago

What does this pull request implement/fix? Explain your changes.

Adds the function overlay_with_emu to the rates plotter such that we can easily compare HW vs Emulated quantities.

This was done before the plotter was updated in the master repo. I have an updated version of this which should play nicely with the updated structure, but I cannot get the master repo to work at all in order to test it...

TypeError: branch L1Upgrade has unsupported type L1Analysis::L1AnalysisL1UpgradeDataFormat Will open an issue to track this.

kreczko commented 6 years ago

BTW: What should be done with this PR?

professor-calculus commented 6 years ago

Nothing I think, it can be killed — unfortuntely the issues in #115 (along with slight analyser style change) delayed the testing and so Aaron got the same features as this added in his PR, sorry about that.