cms-l1t-offline / cmssw

CMS Offline Software
cms-sw.github.io/cmssw
Apache License 2.0
17 stars 27 forks source link

Add Phase-2 Level-1 LLP trigger emulator: TOoLLiP [14_0_0_pre3] #1213

Closed ddiaz006 closed 9 months ago

ddiaz006 commented 9 months ago

PR description:

PR validation:

In progress

ddiaz006 commented 9 months ago

To continue from the previous PR. Here I

ddiaz006 commented 9 months ago

Re Emyr's comment in the last PR: https://github.com/cms-l1t-offline/cmssw/pull/1195#issuecomment-1948939573

I have changed the type so that the code does not crash and I checked edmDumpEventContent to verify that the LLPJets value maps are being saved.

edm::ValueMap<float>                  "l1tTOoLLiPProducer"        "L1PFLLPJets"     "L1P2GT"   
edm::ValueMap<float>                  "l1tTOoLLiPProducerCorrectedEmulator"   "L1PFLLPJets"     "L1P2GT" 
triggerDoctor commented 9 months ago

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

Attempts to compile this PR succeeded!

Info Value
return code 0
command evalscramv1 runtime -sh&& scram b -j 8
triggerDoctor commented 9 months ago

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found no issues with the code checks! Info Value
return code 0
command evalscramv1 runtime -sh&& scram b -k -j 8 code-checks && scram b -k -j 8 code-checks
I found no issues with the headers! Info Value
return code 0
command evalscramv1 runtime -sh&& scram b -k -j 8 check-headers
triggerDoctor commented 9 months ago

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found 2 files that did not meet formatting requirements:

Please run scram b code-format to auto-apply code formatting Info Value
return code 0
command evalscramv1 runtime -sh&& scram b -k -j 8 code-format-all
epalencia commented 9 months ago

@ddiaz006, could you please fix the code format in L1Trigger/Phase2L1ParticleFlow/plugins/TOoLLiPProducer.cc? you can forget about the other one.

triggerDoctor commented 9 months ago

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

Attempts to compile this PR succeeded!

Info Value
return code 0
command evalscramv1 runtime -sh&& scram b -j 8
triggerDoctor commented 9 months ago

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found no issues with the code checks! Info Value
return code 0
command evalscramv1 runtime -sh&& scram b -k -j 8 code-checks && scram b -k -j 8 code-checks
I found no issues with the headers! Info Value
return code 0
command evalscramv1 runtime -sh&& scram b -k -j 8 check-headers
triggerDoctor commented 9 months ago

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found 1 files that did not meet formatting requirements:

Please run scram b code-format to auto-apply code formatting Info Value
return code 0
command evalscramv1 runtime -sh&& scram b -k -j 8 code-format-all
epalencia commented 9 months ago

@aloeliger, i'm fine with merging this PR.

@ddiaz006, could you please port all latest commits to https://github.com/cms-sw/cmssw/pull/43638?

ddiaz006 commented 9 months ago

Thanks, I am trying to update the PR to the main cms-sw, however it appears that I have pulled In some additional changes, how should I proceed? Should I rebase, if so to which target?

aloeliger commented 9 months ago

@ddiaz006 To provide the menu team with validation material, we are going to go ahead and merge this branch into the integration branch. If there are any elements of this that haven't been put in a PR to central CMSSW, please make a PR for that now. Also, I have left some instructions on the main CMSSW PR to help work out the extra commits. @epalencia FYI.