Closed ddiaz006 closed 9 months ago
To continue from the previous PR. Here I
Re Emyr's comment in the last PR: https://github.com/cms-l1t-offline/cmssw/pull/1195#issuecomment-1948939573
I have changed the type so that the code does not crash and I checked edmDumpEventContent to verify that the LLPJets value maps are being saved.
edm::ValueMap<float> "l1tTOoLLiPProducer" "L1PFLLPJets" "L1P2GT"
edm::ValueMap<float> "l1tTOoLLiPProducerCorrectedEmulator" "L1PFLLPJets" "L1P2GT"
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.
Attempts to compile this PR succeeded!
Info | Value |
---|---|
return code | 0 |
command | eval scramv1 runtime -sh&& scram b -j 8 |
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.
I found no issues with the code checks! | Info | Value |
---|---|---|
return code | 0 |
|
command | eval scramv1 runtime -sh&& scram b -k -j 8 code-checks && scram b -k -j 8 code-checks |
I found no issues with the headers! | Info | Value |
---|---|---|
return code | 0 |
|
command | eval scramv1 runtime -sh&& scram b -k -j 8 check-headers |
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.
I found 2 files that did not meet formatting requirements:
Please run scram b code-format to auto-apply code formatting |
Info | Value |
---|---|---|
return code | 0 |
|
command | eval scramv1 runtime -sh&& scram b -k -j 8 code-format-all |
@ddiaz006, could you please fix the code format in L1Trigger/Phase2L1ParticleFlow/plugins/TOoLLiPProducer.cc
? you can forget about the other one.
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.
Attempts to compile this PR succeeded!
Info | Value |
---|---|
return code | 0 |
command | eval scramv1 runtime -sh&& scram b -j 8 |
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.
I found no issues with the code checks! | Info | Value |
---|---|---|
return code | 0 |
|
command | eval scramv1 runtime -sh&& scram b -k -j 8 code-checks && scram b -k -j 8 code-checks |
I found no issues with the headers! | Info | Value |
---|---|---|
return code | 0 |
|
command | eval scramv1 runtime -sh&& scram b -k -j 8 check-headers |
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.
I found 1 files that did not meet formatting requirements:
Please run scram b code-format to auto-apply code formatting |
Info | Value |
---|---|---|
return code | 0 |
|
command | eval scramv1 runtime -sh&& scram b -k -j 8 code-format-all |
@aloeliger, i'm fine with merging this PR.
@ddiaz006, could you please port all latest commits to https://github.com/cms-sw/cmssw/pull/43638?
Thanks, I am trying to update the PR to the main cms-sw, however it appears that I have pulled In some additional changes, how should I proceed? Should I rebase, if so to which target?
@ddiaz006 To provide the menu team with validation material, we are going to go ahead and merge this branch into the integration branch. If there are any elements of this that haven't been put in a PR to central CMSSW, please make a PR for that now. Also, I have left some instructions on the main CMSSW PR to help work out the extra commits. @epalencia FYI.
PR description:
PR validation:
In progress