search

cms-l1t-offline / cmssw

CMS Offline Software
cms-sw.github.io/cmssw
Apache License 2.0
17 stars 27 forks source link

Fix standalone calo barrel EGamma objects #1223

Closed skkwan closed 8 months ago

skkwan commented 8 months ago

PR description:

This PR implements the following fixes and requests for the Phase-2 Calo standalone EGamma objects in the barrel emulator:

  1. Using built-in unsigned integer types for the data member(s) of the digitized collections, instead of ap_uint types which was causing issues (see https://github.com/cms-sw/cmssw/pull/43872)
  2. Changed label names of output objects to avoid duplicates: see this commit diff.
  3. Updated the definitions of the DigitizedClusterCorrelator data format to match the latest specifications, including the working points for isolation and shower shape, with standalone and looseTk of each (four flags in total). For convenience, added methods to get these flags.
  4. Also added methods in DigitizedClusterCorrelator to get the real eta and phi, realEta() and realPhi().
  5. Fixed a bug in the DigitizedClusterCorrelator initialization where the crystal eta convention was incorrect.

PR validation:

The following checks were performed:

  1. Checked that digitizing error is gone, when process.schedule = cms.Schedule(process.pL1EG, process.end) and keep * are used in conjunction
  2. Checked in an event that the DigitizedClusterCorrelator and DigitizedClusterGT give the same leading clusters (pT, eta, phi, working points in the case of the correlator clusters) as the l1tp2::CaloTowerCollection clusters.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Before submitting your pull requests, make sure you followed this checklist:

triggerDoctor commented 8 months ago

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

Attempts to compile this PR succeeded!

Info Value
return code 0
command evalscramv1 runtime -sh&& scram b -j 8
triggerDoctor commented 8 months ago

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found no issues with the code checks! Info Value
return code 0
command evalscramv1 runtime -sh&& scram b -k -j 8 code-checks && scram b -k -j 8 code-checks
I found no issues with the headers! Info Value
return code 0
command evalscramv1 runtime -sh&& scram b -k -j 8 check-headers
triggerDoctor commented 8 months ago

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found 1 files that did not meet formatting requirements:

Please run scram b code-format to auto-apply code formatting Info Value
return code 0
command evalscramv1 runtime -sh&& scram b -k -j 8 code-format-all
triggerDoctor commented 8 months ago

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

Attempts to compile this PR succeeded!

Info Value
return code 0
command evalscramv1 runtime -sh&& scram b -j 8
triggerDoctor commented 8 months ago

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found no issues with the code checks! Info Value
return code 0
command evalscramv1 runtime -sh&& scram b -k -j 8 code-checks && scram b -k -j 8 code-checks
I found no issues with the headers! Info Value
return code 0
command evalscramv1 runtime -sh&& scram b -k -j 8 check-headers
triggerDoctor commented 8 months ago

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found 1 files that did not meet formatting requirements:

Please run scram b code-format to auto-apply code formatting Info Value
return code 0
command evalscramv1 runtime -sh&& scram b -k -j 8 code-format-all
aloeliger commented 8 months ago

This is already merged in CMSSW