cms-l1t-offline / cmssw

CMS Offline Software
cms-sw.github.io/cmssw
Apache License 2.0
17 stars 27 forks source link

Rebasing Btag/Jet type modification to 14_0_0_pre3 #1224

Closed Duchstf closed 8 months ago

Duchstf commented 8 months ago

Discussion in #1198

Duchstf commented 8 months ago

@aloeliger Sorry for the delay again! I feel really bad about this :(

triggerDoctor commented 8 months ago

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

Attempts to compile this PR succeeded!

Info Value
return code 0
command evalscramv1 runtime -sh&& scram b -j 8
triggerDoctor commented 8 months ago

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found no issues with the code checks! Info Value
return code 0
command evalscramv1 runtime -sh&& scram b -k -j 8 code-checks && scram b -k -j 8 code-checks
I found no issues with the headers! Info Value
return code 0
command evalscramv1 runtime -sh&& scram b -k -j 8 check-headers
triggerDoctor commented 8 months ago

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found 1 files that did not meet formatting requirements:

Please run scram b code-format to auto-apply code formatting Info Value
return code 0
command evalscramv1 runtime -sh&& scram b -k -j 8 code-format-all
Duchstf commented 8 months ago

I don't think this file was changed at all in this PR.

epalencia commented 8 months ago

Yes, that is correct, don't worry about it.

Duchstf commented 8 months ago

@epalencia so can this be merged now?

aloeliger commented 8 months ago

@Duchstf We'll go ahead and merge this now for v6. If there isn't already a PR for this to central, please go ahead and make it.