Closed EmyrClement closed 7 months ago
I ran my physics validation, and all looks good:
I see the expected performance for calo jets, calo taus, and NN Calo Taus, which shows each algorithm is picking up the correct HGCal towers.
Note that I have included by hand the latest callibrations from Victor i.e. they are not yet in a PR as far as I am aware. Perhaps I could include that change in this PR.
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.
Attempts to compile this PR succeeded!
Info | Value |
---|---|
return code | 0 |
command | eval scramv1 runtime -sh&& scram b -j 8 |
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.
I found no issues with the code checks! | Info | Value |
---|---|---|
return code | 0 |
|
command | eval scramv1 runtime -sh&& scram b -k -j 8 code-checks && scram b -k -j 8 code-checks |
I found no issues with the headers! | Info | Value |
---|---|---|
return code | 0 |
|
command | eval scramv1 runtime -sh&& scram b -k -j 8 check-headers |
Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.
I found 1 files that did not meet formatting requirements:
Please run scram b code-format to auto-apply code formatting |
Info | Value |
---|---|---|
return code | 0 |
|
command | eval scramv1 runtime -sh&& scram b -k -j 8 code-format-all |
@epalencia I think I have nothing here, if there's nothing from your side, @EmyrClement Would you go ahead and make a PR for this to central CMSSW, and we'll merge it here.
Nothing from my side as well.
@EmyrClement Could you please open a PR for this code to CMSSW as soon as convenient?
I opened it last week : https://github.com/cms-sw/cmssw/pull/44571
PR description:
This PR adds the production of the non-default energy split HGCal towers for use by the baseline GCT jets and taus. The GCT NN Calo Tau algorithm still uses the default towers.
I've marked it as draft as I still need to check the performance of the GCT objects look as expected with this change. However I wanted to start the review of the code (i.e. check what I have done is acceptable) in parallel to the physics validation given the urgency.
PR validation:
Ran the L1 sequence for the v5 recipe. Performance validation ongoing.
@pallabidas can you and Victor also check this PR? Perhaps we can merge this PR with the update of the GCT calibrations when going to master?