cms-l1t-offline / cmssw

CMS Offline Software
cms-sw.github.io/cmssw
Apache License 2.0
17 stars 27 forks source link

Produce and use custom HGCal towers for baseline GCT calo jets and taus. #1226

Closed EmyrClement closed 7 months ago

EmyrClement commented 8 months ago

PR description:

This PR adds the production of the non-default energy split HGCal towers for use by the baseline GCT jets and taus. The GCT NN Calo Tau algorithm still uses the default towers.

I've marked it as draft as I still need to check the performance of the GCT objects look as expected with this change. However I wanted to start the review of the code (i.e. check what I have done is acceptable) in parallel to the physics validation given the urgency.

PR validation:

Ran the L1 sequence for the v5 recipe. Performance validation ongoing.

@pallabidas can you and Victor also check this PR? Perhaps we can merge this PR with the update of the GCT calibrations when going to master?

EmyrClement commented 8 months ago

I ran my physics validation, and all looks good:

Jet matching efficiency and rate vs L1 threshold

JetMatching_Eta_Pt100ToInf_-999_V33nano V33nano_Online_JetDefaultRates

Tau matching efficiency and rate vs L1 threshold

TausMatchingBarrel_-999_V33nano TausMatchingEndcap_-999_V33nano V33nano_Online_TauRates

I see the expected performance for calo jets, calo taus, and NN Calo Taus, which shows each algorithm is picking up the correct HGCal towers.

Note that I have included by hand the latest callibrations from Victor i.e. they are not yet in a PR as far as I am aware. Perhaps I could include that change in this PR.

triggerDoctor commented 8 months ago

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

Attempts to compile this PR succeeded!

Info Value
return code 0
command evalscramv1 runtime -sh&& scram b -j 8
triggerDoctor commented 8 months ago

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found no issues with the code checks! Info Value
return code 0
command evalscramv1 runtime -sh&& scram b -k -j 8 code-checks && scram b -k -j 8 code-checks
I found no issues with the headers! Info Value
return code 0
command evalscramv1 runtime -sh&& scram b -k -j 8 check-headers
triggerDoctor commented 8 months ago

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found 1 files that did not meet formatting requirements:

Please run scram b code-format to auto-apply code formatting Info Value
return code 0
command evalscramv1 runtime -sh&& scram b -k -j 8 code-format-all
aloeliger commented 7 months ago

@epalencia I think I have nothing here, if there's nothing from your side, @EmyrClement Would you go ahead and make a PR for this to central CMSSW, and we'll merge it here.

epalencia commented 7 months ago

Nothing from my side as well.

aloeliger commented 7 months ago

@EmyrClement Could you please open a PR for this code to CMSSW as soon as convenient?

EmyrClement commented 7 months ago

I opened it last week : https://github.com/cms-sw/cmssw/pull/44571