search

cms-l1t-offline / cmssw

CMS Offline Software
cms-sw.github.io/cmssw
Apache License 2.0
17 stars 27 forks source link

bug fixes for tracktriplet #1245

Closed gkaratha closed 7 months ago

gkaratha commented 7 months ago

Few bug fixes for the trackjet emulator. There are 3 changes: 1) Change in the data formats: just for convinience I used one liners in the .h 2) Few fixes on the actual code 3) Adding the module in L1Nano schedule I have tested that the results are correct

Let me know for comments. I will do a PR in central as well.

triggerDoctor commented 7 months ago

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

Attempts to compile this PR succeeded!

Info Value
return code 0
command evalscramv1 runtime -sh&& scram b -j 8
triggerDoctor commented 7 months ago

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found no issues with the code checks! Info Value
return code 0
command evalscramv1 runtime -sh&& scram b -k -j 8 code-checks && scram b -k -j 8 code-checks
I found no issues with the headers! Info Value
return code 0
command evalscramv1 runtime -sh&& scram b -k -j 8 check-headers
triggerDoctor commented 7 months ago

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found 5 files that did not meet formatting requirements:

Please run scram b code-format to auto-apply code formatting Info Value
return code 0
command evalscramv1 runtime -sh&& scram b -k -j 8 code-format-all
triggerDoctor commented 7 months ago

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

This PR passes available unit tests! Info Value
return code 0
command evalscramv1 runtime -sh&& scram b runtests
triggerDoctor commented 7 months ago

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation

I found a non-zero return code running the relval workflows for this PR! Info Value
return code 1
command evalscramv1 runtime -sh&& runTheMatrix.py --what upgrade -l 26834.78
gkaratha commented 7 months ago

here is the pr in central https://github.com/cms-sw/cmssw/pull/44677