search

cms-l1t-offline / cmssw

CMS Offline Software
cms-sw.github.io/cmssw
Apache License 2.0
17 stars 27 forks source link

Phase 2 GTT Add Extended Jets to buffers for GlobalTrigger #1248

Open NJManganelli opened 7 months ago

NJManganelli commented 7 months ago

PR description:

This PR adds the GTT Displaced TrackJets into the emulation buffers from GTT to GlobalTrigger

As with the PR to add displaced HT, this is not time-critical, but also does not affect workflows for the AR (only being called by GTT F/W Emulation buffer workflow, createFirmwareInputFiles_cfg.py)

PR validation:

scram b code-checks scram b code-format scram b cmsRun createFirmwareInputFiles_cfg.py maxEvents=1000 format=APx inputFiles=... --> inserts Displaced TrackJet words into GTT buffers for OutputToGlobalTrigger

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This will need a forward-port to master

NJManganelli commented 7 months ago

If this gets approved, maintainers feel free to convert the PR to master from Draft (or I can do so whenever); no expected changes except ones needed here.

aloeliger commented 7 months ago

@NJManganelli I would take this straight to CMSSW. I am hopeful that we are going to add in a bunch of muon PRs and then close v9 and this round of phase 2 AR upgrades. I don't want this to just languish here, so just having it in central CMSSW will be the the quickest way to get it into the next AR IB (If one gets made, if I have my way we will make this whole fork obsolete in favor of just operating in central CMSSW).

NJManganelli commented 7 months ago

Getting rid of IB(s) would be great! I'll convert the master PR to fully open

triggerDoctor commented 7 months ago

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

Attempts to compile this PR succeeded!

Info Value
return code 0
command evalscramv1 runtime -sh&& scram b -j 8
triggerDoctor commented 7 months ago

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found no issues with the code checks! Info Value
return code 0
command evalscramv1 runtime -sh&& scram b -k -j 8 code-checks && scram b -k -j 8 code-checks
I found no issues with the headers! Info Value
return code 0
command evalscramv1 runtime -sh&& scram b -k -j 8 check-headers
triggerDoctor commented 7 months ago

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found 2 files that did not meet formatting requirements:

Please run scram b code-format to auto-apply code formatting Info Value
return code 0
command evalscramv1 runtime -sh&& scram b -k -j 8 code-format-all
triggerDoctor commented 7 months ago

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

This PR passes available unit tests! Info Value
return code 0
command evalscramv1 runtime -sh&& scram b runtests
triggerDoctor commented 7 months ago

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation

I found a non-zero return code running the relval workflows for this PR! Info Value
return code 1
command evalscramv1 runtime -sh&& runTheMatrix.py --what upgrade -l 26834.78