cms-l1t-offline / cmssw

CMS Offline Software
cms-sw.github.io/cmssw
Apache License 2.0
17 stars 27 forks source link

ntuplemaker fixes #1253

Open cgsavard opened 6 months ago

cgsavard commented 6 months ago

PR description:

This PR will fix a couple of bugs to the ntuplemaker:

  1. The vertex variables are not being cleared when SaveTrackJets is false because the clearing is in the wrong place. This is fixed by moving it outside of the boolean.
  2. The vertexing algorithm name when not running the NN does not reference anything so it's default to the fasthisto algo. Theoretically it should be fasthisto so the hard coded name in the config was removed as fasthisto is already default.
  3. The current default file is not available. It has been replaced with a TT file that is accessible.
  4. The HYBRID method needs a process.pL1TrackTripletEmulator to run so it has now been set.
triggerDoctor commented 6 months ago

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

Attempts to compile this PR succeeded!

Info Value
return code 0
command evalscramv1 runtime -sh&& scram b -j 8
triggerDoctor commented 6 months ago

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found no issues with the code checks! Info Value
return code 0
command evalscramv1 runtime -sh&& scram b -k -j 8 code-checks && scram b -k -j 8 code-checks
I found no issues with the headers! Info Value
return code 0
command evalscramv1 runtime -sh&& scram b -k -j 8 check-headers
triggerDoctor commented 6 months ago

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found 3 files that did not meet formatting requirements:

Please run scram b code-format to auto-apply code formatting Info Value
return code 0
command evalscramv1 runtime -sh&& scram b -k -j 8 code-format-all
triggerDoctor commented 6 months ago

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

This PR passes available unit tests! Info Value
return code 0
command evalscramv1 runtime -sh&& scram b runtests
triggerDoctor commented 6 months ago

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation

I found a non-zero return code running the relval workflows for this PR! Info Value
return code 1
command evalscramv1 runtime -sh&& runTheMatrix.py --what upgrade -l 26834.78