search

cms-l1t-offline / cmssw

CMS Offline Software
cms-sw.github.io/cmssw
Apache License 2.0
17 stars 27 forks source link

L1T Private Integration Branch based on CMSSW_8_0_9 #346

Open rekovic opened 8 years ago

rekovic commented 8 years ago

The 808 integration branch has been adjusted to better line up with what will be in CMSSW, by rebasing to CMSSW 809.

The branch is located here: https://github.com/cms-l1t-offline/cmssw/tree/l1t-integration-CMSSW_8_0_9

Bitwise agreement in integration tests demonstrated between l1t-integration-v61.1-CMSSW_8_0_9 and l1t-integration-v61.1 (under 808).

Tags:

The change log of development integration is here

Recipe:

cmsrel CMSSW_8_0_9
cd CMSSW_8_0_9/src
cmsenv
git cms-init
git remote add cms-l1t-offline git@github.com:cms-l1t-offline/cmssw.git
git fetch cms-l1t-offline
git cms-merge-topic --unsafe cms-l1t-offline:l1t-integration-v78.0
scram b -j 8

Notes: The L1 re-emulation from MC RAWAODSIM eventcontent is now also available through L1REPACK:FullMC step, which repacks into RAW the new re-emulated L1 products, and will be used in the MP production. The example below uses this step and fills L1Ntuples with information from these re-packed products.

cmsDriver.py  --conditions 80X_mcRun2_asymptotic_v14  -s L1REPACK:FullMC,RAW2DIGI --no_output -n 10 --era=Run2_2016 --filein root://eoscms.cern.ch//eos/cms/store/mc/RunIISpring16DR80/TTJets_TuneCUETP8M1_13TeV-amcatnloFXFX-pythia8/RAWAODSIM/PUSpring16RAWAODSIM_80X_mcRun2_asymptotic_2016_v3-v2/30000/040AFBF1-8E0B-E611-9C22-001E67E95A58.root --processName reL1T --python_filename l1t_test.py --customise=L1Trigger/L1TNtuples/customiseL1Ntuple.L1NtupleRAW

To also fill the RECO information in the L1TNtuples , change the customisation to

--customise=L1Trigger/L1TNtuples/customiseL1Ntuple.L1NtupleAODRAW
mulhearn commented 8 years ago

Just making some comments about whats already in CMSSW relative to this branch, since things got a bit non-linear.

1) CMSSW_8_0_9 is l1t-integration-v54.0-CMSSW_8_0_8 (= l1t-tsg-v7) plus additional commits for OMTF boundaries and setting default tau isolate working point to Option 21.

mulhearn@cmsdev01>git log --pretty=oneline l1t-integration-v60.0..l1t-integration-v61.0
a1daf680d80854b8bb964e5540926abc93658dae Change default caloParams to use Tau Iso Option 21 (caloStage2Params_2016_v2_2_cfi)

mulhearn@cmsdev01>git log --pretty=oneline l1t-integration-v58.1-CMSSW_8_0_8..l1t-integration-v59.0
19ec5dcc028789b0b415c9b540f19e804a62b55e In case of |eta| 121 set its quality to 4. It has no effect for MC shince hits with this quality are filtered out, but is usefull for data-MC compar
5a629fea2999f01926e9eae22805d20d6eb0d19b slightly tune/modify condition of q=4 for |eta|==115. Now it is done if in case |eta|==115 and hits are ONLY in 3 layers out of (7,8,9,17)
44676e061557b5e0d1959887ba41edc1e9a912e6 assigne eta=+-121 to CSC hits with keyWG above |eta|=1.3, then filter them set q=4 to muons with |eta|=115, remove layers 7,8,9 from list of layers 
5e4e0e57f4663eafd896a0b908c06f48b347b356 Merged l1t-integration-CMSSW_8_0_8 from repository cms-l1t-offline

I confirmed that CMSSW_8_0_9 is bitwise equivalent to l1t-tsg-integration-v54.0-CMSSW_8_0_8 plus those commits above under 808.

2) CMSSW_8_0_10 has no changes to l1t algorithms. This was confirmed as well.

3) CMSSW_8_0_11 added the revert of "optimized cancel out" parameters of Dinyar:

mulhearn@cmsdev01>git log --pretty=oneline l1t-integration-v63.1..l1t-integration-v64.0
ef9ef7a219595e28c8c412e36ea0a5f1e1476de3 Revert "Optimised cancel out window parameters from Dinyar"

I checked that 808 + tsg-v7 + all five of above commits is bitwise equivalent to 8_0_11.

4) I suggest we define l1t-tsg-v7 = l1t-tsg-v7-cand by the way. Its been about a month ;-)

5) I suggest we define l1t-tsg-v8-cand now under 809 and prepare a small PR to bring CMSSW fully up to date with this integration branch.