O2O Updates - Githubissues

cms-l1t-offline / cmssw

CMS Offline Software

cms-sw.github.io/cmssw

Apache License 2.0

17 stars 26 forks source link

O2O Updates #400

Open mulhearn opened 8 years ago

mulhearn commented 8 years ago

The first pass PRs which includes many updates (even since Stage 1) and the Stage 2 L1 menu O2O is here:

81x: https://github.com/cms-sw/cmssw/pull/15243 (merged)
80x: https://github.com/cms-sw/cmssw/pull/15204 (fully signed)

The next pass PR will be based (for 80x) this branch in work:

https://github.com/kkotov/cmssw/tree/fullL1TO2Ofor80X (Includes everything including Calo Layer2 and capitalization fixes for parser, which requires some updates)
This is ready for testing and review by Mike.

mulhearn commented 8 years ago

This has been tested online with CMSSW_8_0_15 and the O2O machinery works. (details to follow).

kkotov commented 8 years ago

Verified all payloads:

L1TUtmTriggerMenu - no change wrt. previous version (as expected)

L1TGlobalPrescalesVetos - no change (as expected)

L1TMuonOverlapParams - no change (as expected)

L1TMuonEndcapParams - changed as expected, not yet in use anywhere

L1TMuonBarrelParams - changed, waiting for Giannis to validate it

CaloParams:

Layer1 - online DB match the available static configs in all but one entry of inlayer1ECalScaleFactors vector: 1.4931 vs. 1.4932 (must be some harmless rounding issue)
Layer2 (new) - validated by comparing agreement between data and emulator for run 276403:
- Jets - 100% agreement
- Tau - expected disagreement, wait for Olivier change
- Eg - payloads bitwise 100% agree between online DB and caloStage2Params_2016_v2_2_cfi.py in CMSSW_8_0_9

kkotov commented 8 years ago

After the https://github.com/cms-sw/cmssw/pull/15204 PR will be merged, I propose to go forward with two new PRs for my new fullL1TO2Ofor80X and fullL1TO2Ofor81X branches

koskot77 commented 8 years ago

Although, before PRing we can also straighten out some "private" solutions bypassing the need to change CondFormats. For example one of these home-breed solutions: https://github.com/kkotov/cmssw/blob/fullL1TO2Ofor80X/L1Trigger/L1TMuon/interface/L1TMuonGlobalParams_PUBLIC.h do nothing else, but simply substitutes "private" for "public" in https://github.com/kkotov/cmssw/blob/fullL1TO2Ofor80X/CondFormats/L1TObjects/interface/L1TMuonGlobalParams.h#L215