search

cms-l1t-offline / cmssw

CMS Offline Software
cms-sw.github.io/cmssw
Apache License 2.0
17 stars 27 forks source link

Change to "l1pfProducerTune2018" also for Puppi objects #734

Open mcepeda opened 5 years ago

mcepeda commented 5 years ago

Hi @rekovic - the final objects are the puppi ones, can you also adapt line L159 and L174?

https://github.com/cms-l1t-offline/cmssw/blob/1fd140b0056ca12b962eea3a03b1f28250d15833/L1Trigger/Configuration/python/SimL1Emulator_cff.py#L159

https://github.com/cms-l1t-offline/cmssw/blob/l1t-phase2-v2.16.44/L1Trigger/Configuration/python/SimL1Emulator_cff.py#L174

gpetruc commented 5 years ago

The tighter PUPPI tune was tested only on MET, while here I see it being used also for jets. Has there been any study of comparing the performance for jets and HT before changing the configuration for those?

On Wed, Nov 28, 2018 at 9:18 AM Maria Cepeda notifications@github.com wrote:

Hi @rekovic https://github.com/rekovic - the final objects are the puppi ones, can you also adapt line L159 and L174?

https://github.com/cms-l1t-offline/cmssw/blob/1fd140b0056ca12b962eea3a03b1f28250d15833/L1Trigger/Configuration/python/SimL1Emulator_cff.py#L159

https://github.com/cms-l1t-offline/cmssw/blob/l1t-phase2-v2.16.44/L1Trigger/Configuration/python/SimL1Emulator_cff.py#L174

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/cms-l1t-offline/cmssw/issues/734, or mute the thread https://github.com/notifications/unsubscribe-auth/AEbbR-Ah7gH0AQjHTK0zp1HaDiW17M6sks5uzkbAgaJpZM4Y3E3K .

mcepeda commented 5 years ago

Not yet. I am integrating this PR right now for testing in the menu and git flagged this as a merge problem. My comment was mainly that if we change something, it should be for PUPPI, not for "PF".

Note line 173 right now: https://github.com/cms-l1t-offline/cmssw/blob/l1t-phase2-v2.16.44/L1Trigger/Configuration/python/SimL1Emulator_cff.py#L173 - if you do not want this, then I think the change should be in line 159 to include the tune for PUPPIMET and in line 173 to remove it from PFJETs.