Closed IzaakWN closed 4 years ago
I've merged #453 that was opened before, could you please adapt these changes on top of that? (please rebase, do not fix the confict while merging, because that makes it difficult to backport these changes to other CMSSW branches)
Okay, I'll rebase my repo, but keep this PR if that's okay.
Do you prefer to keep the electron trigger object consolidated for all years?
Also, for the muon objects, should I copy the other bits (16 = 2mu, 32 = 1mu-1e, 64 = 1mu-1tau, 128 = 3mu, 256 = 2mu-1e, 512 = 1mu-2e
) to 2016? Not an expert, and I have not checked whether these patterns cover the equivalent 2016 triggers, but it does not affect the other bits. Otherwise, do you know where is there a comprehensive list for these 2016 triggers?
Yes, it would be better to keep the electron object consolidated as introduced by #453. For muons, unfortunately I don't have expertise to really answer that question. I would leave things as they are for the moment, and follow up with experts at a later moment.
Automatic test started, see https://gitlab.cern.ch/cms-nanoAOD/nanoAOD-integration/pipelines/1256882/builds
Automatic test started, see https://gitlab.cern.ch/cms-nanoAOD/nanoAOD-integration/pipelines/1257170/builds
PR description:
Add high pT electron and muon triggers, targeting those that are recommended [1-5]:
Ele50*PFJet*
can be exclusively selected with bits2048+4096
. To be more exclusive forMu50
andMu100
,HLT_Photon175
andPhoton200
, the pT trigger thresholds are included in the filter bit patterns:The selection of the muon trigger objects had to change to include the corresponding filters [5]:
The documentation is updated:
One thing that should still be added is the emu and double muon/electron trigger objects for 2016.
[1] https://twiki.cern.ch/twiki/bin/view/CMS/MuonHLT2016#Recommended_trigger_paths_for_20 [2] https://twiki.cern.ch/twiki/bin/view/CMS/MuonHLT2017#Recommendations_for_2017_data_an [3] https://twiki.cern.ch/twiki/bin/view/CMS/MuonHLT2018#Recommended_trigger_paths_for_20 [4] https://twiki.cern.ch/twiki/bin/view/CMS/EgHLTRunIISummary#Short_Summary_Recommended_Trigge [5] https://github.com/IzaakWN/cmssw/commit/67d5a4c7db373f2ebd59149cdebbb29cd9e8cd32#diff-0fbc78c42b3703f21323e95fb1320981R63
PR validation:
Validated locally with 2016/2017/2018 data and MC that the bits are added in the expected way for the respective triggers. Checked as well that the changes in selection for the muon trigger object did not change the number of objects for the other filterbits.