search

cms-nanoAOD / cmssw

CMS NanoAOD software integration repository
http://cms-sw.github.io/
Apache License 2.0
3 stars 10 forks source link

Electron IP sign #514

Closed swertz closed 4 years ago

swertz commented 4 years ago

In #479 the sign of the 2D IP (dxy) for muons was fixed, and if I understand correctly the issue was fixed upstream in PAT (here https://github.com/cms-sw/cmssw/pull/28753) by switching from using IPTools::signedTransverseImpactParameter() to reco::TrackBase::dxy().

However it seems that PAT electrons still use signedTransverseImpactParameter(): https://github.com/cms-nanoAOD/cmssw/blob/master/PhysicsTools/PatAlgos/plugins/PATElectronProducer.cc#L1150-L1159

Is there a reason why this wasn't changed for electrons?

peruzzim commented 4 years ago

to be discussed offline

arizzi commented 4 years ago

was it discussed?

swertz commented 4 years ago

Didn't have any reply, I'll send a reminder.

swertz commented 4 years ago

Fixed in https://github.com/cms-sw/cmssw/pull/30738 (+ backport to 106X). Not sure if a fix a la #479 for non-UL is also needed?

mariadalfonso commented 4 years ago

@swertz Thanks for this check. indeed a fix like this for the OLD miniAOD is beneficial especially if we go for the re-nano of the UL before doing the re-mini.

mariadalfonso commented 4 years ago

For miniAOD it's taken care starting from the reminiAOD of the UL. For nano made from previously made mini, the PR linked above fixed the issue.